Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enable config parameter for legacy PNP signer endpoints #9967

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Add enable config parameter for legacy PNP signer endpoints #9967

merged 4 commits into from
Oct 21, 2022

Conversation

eelanagaraj
Copy link
Contributor

@eelanagaraj eelanagaraj commented Oct 21, 2022 •
edited
Loading

Description

  • Tiny PR to make it possible to disable the legacy PNP signer endpoints (separately from the new PNP signer endpoints) by updating the config file (as opposed to requiring updating versions)
  • For now, not doing this on the combiner side since it involves duplicating a larger section of the config file, and since we are in control of redeploying/changing the combiner, we can always allocate time as needed to do this later

driveby (unrelated to the rest of this PR but super small)

  • Removed a line that looks unintentional in the common/src/test/utils file that breaks the yarn start command in the signer
  • Fixes an import/removes the wallet-rpc dependency which looks like a mistake?

@eelanagaraj eelanagaraj requested a review from a team as a code owner October 21, 2022 13:25
@eelanagaraj eelanagaraj requested a review from a team October 21, 2022 13:25
@eelanagaraj eelanagaraj requested a review from a team as a code owner October 21, 2022 13:25
@eelanagaraj eelanagaraj changed the base branch from master to odisCip40 October 21, 2022 13:25
@eelanagaraj eelanagaraj requested review from alecps and removed request for a team and lvpeschke October 21, 2022 13:25
alecps
alecps approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@alecps alecps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@alecps alecps merged commit e9601d4 into odisCip40 Oct 21, 2022
@leojoy95 leojoy95 mentioned this pull request Jun 21, 2023
Open
This was referenced Jun 30, 2023
Open
Open
Open
Open
Open
@lili2311 lili2311 mentioned this pull request Jul 1, 2023
Open
This was referenced Jul 4, 2023
Open
Open
This was referenced Jul 12, 2023
Open
Open
@lili2311 lili2311 mentioned this pull request Aug 15, 2023
Open
@lvpeschke lvpeschke deleted the eelanagaraj/add-enable-config-params branch November 9, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecps alecps alecps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eelanagaraj @alecps